Review 11.5 Merged

76013[TASK] Update to PHPStan 1.8.8

Oliver Klee CR +2 V +2 Normal +27 −27 updated 10/07/22, 21:04

Commit message

This update finds new problems and gets rid of some
false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.8.8
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Oliver Klee commented on patch set 1 10/07/22, 07:50

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.lock
  2. core-ci voted on patch set 1 V -1 10/07/22, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32066

  3. Oliver Klee uploaded patch set 2 10/07/22, 07:56

  4. Oliver Klee marked it ready for review 10/07/22, 07:56

  5. core-ci voted on patch set 2 V +1 10/07/22, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32067

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 10/07/22, 08:47

  7. Christian Kuhn updated the commit message in patch set 3 10/07/22, 20:14

  8. core-ci voted on patch set 3 V +1 10/07/22, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32086

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 10/07/22, 21:04

  10. Christian Kuhn merged patch set 4 10/07/22, 21:04