Review 11.5 Merged

76413[BUGFIX] Resolve modified slugs in versioned pages of preview

Benni Mack CR +2 V +2 Normal +133 −24 updated 11/04/22, 08:05

Commit message

This change now also fetches versioned records when
previewing a workspace, allowing to also query the
versioned records if their slug has been changed.

This extends WorkspaceRestriction to have a similar
behaviour as previously known from PageRepository (pre v8 times),
to fetch versioned records.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 813

  1. Benni Mack commented on patch set 1 11/03/22, 16:40

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Database/Query/Restriction/WorkspaceRestriction.php
  2. Benni Mack commented on patch set 2 11/03/22, 16:42

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 11/03/22, 16:42

  4. core-ci voted on patch set 1 V -1 11/03/22, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33058

  5. core-ci voted on patch set 2 V -1 11/03/22, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33059

  6. Benni Mack commented on patch set 3 11/03/22, 17:10

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V -1 11/03/22, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33063

  8. Benni Mack rebased onto patch set 4 11/03/22, 20:02

  9. core-ci voted on patch set 4 V -1 11/03/22, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33080

  10. Benni Mack commented on patch set 5 11/03/22, 20:40

    Published edit on patch set 4.
  11. core-ci voted on patch set 5 V +1 11/03/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33083

  12. Benni Mack voted on patch set 5 V +2 CR +2 11/04/22, 08:05

  13. Benni Mack merged patch set 6 11/04/22, 08:05