Review 12.1 Merged

77134[BUGFIX] Prevent undefined global variable in BackendConfigurationManager

Benni Mack CR +2 V +2 Easy +9 −6 updated 12/14/22, 13:10

Commit message

$GLOBALS['TYPO3_REQUEST'] might be undefined,
e.g. in CLI context. This is now handled properly.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack commented on patch set 1 12/14/22, 08:22

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 12/14/22, 08:26

  3. core-ci voted on patch set 1 V -1 12/14/22, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35081

  4. Oliver Hader rebased onto patch set 2 CR +1 V -1 12/14/22, 13:00

  5. core-ci voted on patch set 2 V +1 12/14/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35100

  6. Oliver Hader voted on patch set 2 CR +2 12/14/22, 13:10

  7. Oliver Hader voted on patch set 2 V +2 12/14/22, 13:10

  8. Oliver Hader merged patch set 3 12/14/22, 13:10