Review 11.5 Merged

77212[TASK] Update to PHPStan 1.9.4

Benni Mack CR +2 V +2 Easy +24 −19 updated 12/20/22, 16:52

Commit message

The new version finds some more potential problems.

> composer req --dev phpstan/phpstan:^1.9.4
> composer req --dev phpstan/phpstan-phpunit:^1.3.2
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 12/20/22, 16:07

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock
  2. core-ci voted on patch set 1 V -1 12/20/22, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35244

  3. Benni Mack uploaded patch set 2 V -1 12/20/22, 16:18

  4. Benni Mack marked it ready for review 12/20/22, 16:18

  5. core-ci voted on patch set 2 V +1 12/20/22, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35245

  6. Benni Mack voted on patch set 2 V +2 CR +2 12/20/22, 16:52

  7. Benni Mack merged patch set 3 12/20/22, 16:52