Review 11.5 Merged

77440[BUGFIX] Handle disabled default language in PageContentErrorHandler

Oli Bartsch CR +2 V +2 Easy +12 −0 updated 01/23/23, 20:10

Commit message

The SiteInterface provides the "getDefaultLanguage()"
method, which will always return the first configured
language - usually L=0. However, this language might
be disabled, which means, it should not be visible
in frontend context.

The PageContentErrorHandler therefore now tries
to fetch the first enabled language, in case the
requested language id does not exist in the current
site and the sites' default language is disabled.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 01/23/23, 19:56

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/23/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36494

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 01/23/23, 20:10

  4. Oli Bartsch merged patch set 2 01/23/23, 20:10