Review main Merged

77735[TASK] Improve comments and readability in PageArgumentValidator

Benjamin Franzke CR +2 V +2 Easy +7 −6 updated 02/07/23, 09:11

Commit message

Make clear that the early-bail out for empty pageArguments is
done to prevent setting `disableCaches` to `true`.

Also makes that that the $pageNotFoundOnCacheHashError
condition is really tied to pageArguments being non-empty.
Prevents us from refactoring that code and missing this bit.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Benjamin Franzke uploaded patch set 1 02/07/23, 07:29

  2. Benjamin Franzke commented on patch set 1 02/07/23, 07:31

    As this is a followup to: https://review.typo3.org/77728 It makes most sense to view this as: git diff aa057bfccfb4a6d34900bb894635149174df2c4b^ -- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php
  3. core-ci voted on patch set 1 V +1 02/07/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37251

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 02/07/23, 08:31

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 02/07/23, 08:55

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/07/23, 09:10

  7. Benjamin Franzke merged patch set 2 02/07/23, 09:11