Review 11.5 Merged

77756[BUGFIX] Sort and limit available locales in SiteLanguage selection

Benni Mack CR +2 V +2 Hard +320 −1 updated 02/10/23, 21:10

Commit message

When showing the available locales in the SiteLanguage
configuration, the selection is now sorted and also filtered,
by only showing "de_DE" and skipping locales with modifiers,
such as "de_DE.UTF-8" or "de_DE.ISO8859-1" in order to make
life easier for integrators.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 69

  1. Benni Mack commented on patch set 1 02/10/23, 20:18

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Localization/Locale.php * typo3/sysext/core/Tests/Unit/Localization/LocaleTest.php
  2. Benni Mack commented on patch set 2 02/10/23, 20:19

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 02/10/23, 20:19

  4. core-ci voted on patch set 2 V -1 02/10/23, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37580

  5. core-ci voted on patch set 1 V -1 02/10/23, 20:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37579

  6. Benni Mack uploaded patch set 3 V -1 02/10/23, 20:50

  7. core-ci voted on patch set 3 V +1 02/10/23, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37582

  8. Benni Mack voted on patch set 3 V +2 CR +2 02/10/23, 21:09

  9. Benni Mack merged patch set 4 02/10/23, 21:10