Review 12.1 Merged

77964[TASK] Switch to custom build docker-dind image

Stefan Bürk CR +2 V +2 Easy +7 −2 updated 03/05/23, 02:21

Commit message

Due a regression since GitLab runner 15.1,we cannot
use the official docker dind image to raise runner
version to keep up with the TYPO3 gitlab instance.

Because of other issues, using a custom docker dind
image with changed expose port for the healthcheck
to work around that issue is needed.

See: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29130

After Gitlab has released a proper fix for this,
this should be reverted and the official docker
dind image used again.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Stefan Bürk commented on patch set 1 03/04/23, 18:31

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 03/04/23, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38452

  3. Stefan Bürk uploaded patch set 2 V -1 03/05/23, 02:02

  4. core-ci voted on patch set 2 V +1 03/05/23, 02:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38471

  5. Stefan Bürk commented on patch set 2 03/05/23, 02:21

    Bending the rules and merging this without votes to get core ci working again for all branches.
  6. Stefan Bürk voted on patch set 2 V +2 CR +2 03/05/23, 02:21

  7. Stefan Bürk merged patch set 3 03/05/23, 02:21