Review 11.5 Merged

77991[TASK] Ensure type safety in YamlFileLoader

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 03/01/23, 12:10

Commit message

The method getFileContents has return type string. However it contains
a call to file_get_contents, that can return a boolean in case of failure.
Added a check for if the file is readable and a cast to string when
returning the value of the call to file_get_contents.
In case of failure it will return the empty string, which will be caught
properly in the method loadAndParse. Afterwards the error handling could
be improved in loadAndParse to be more specific.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 03/01/23, 11:56

  2. core-ci voted on patch set 1 V +1 03/01/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38261

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 03/01/23, 12:10

  4. Christian Kuhn merged patch set 2 03/01/23, 12:10