#100048Ensure that getFileContents returns correct type in YamlFileLoader
Description
The method getFileContents in YamlFileLoader has return type string, but it has
a call to file_get_contents that can return string or false. Ensure that a string
is always returned.
Reviews 2
Related issues 1
History 410
-
Thomas Hohn changed subject
Ensure that getFileContents returns correct typeEnsure that getFileContents returns correct type in YamlFileLoader 02/28/23, 18:04 -
Gerrit Code Review pushed patch set 1 for main to change 77984 status
NewUnder Review 02/28/23, 18:14 -
Gerrit Code Review pushed patch set 2 for main to change 77984 02/28/23, 18:22
-
Simon Schaufelberger changed Related to #99926 03/01/23, 00:03
-
Gerrit Code Review pushed patch set 3 for main to change 77984 03/01/23, 05:04
-
Gerrit Code Review pushed patch set 4 for main to change 77984 03/01/23, 10:08
-
Gerrit Code Review pushed patch set 5 for main to change 77984 03/01/23, 10:15
-
Gerrit Code Review pushed patch set 1 for 11.5 to change 77991 03/01/23, 11:56
-
Thomas Hohn commented and changed status
Under ReviewResolved done0 %100 % 03/01/23, 12:15 -
Benni Mack changed status
ResolvedClosed 01/30/24, 09:06
Applied in changeset commit:86d1f36c7ca2bcef3316dd1008603441fa23a534.