Issue Task Closed

#100048Ensure that getFileContents returns correct type in YamlFileLoader

Thomas Hohn 02/28/23, 17:58 updated 01/30/24, 09:06

Description

The method getFileContents in YamlFileLoader has return type string, but it has
a call to file_get_contents that can return string or false. Ensure that a string
is always returned.

Reviews 2

History 410

  1. Thomas Hohn changed subject Ensure that getFileContents returns correct type Ensure that getFileContents returns correct type in YamlFileLoader 02/28/23, 18:04

  2. Gerrit Code Review pushed patch set 1 for main to change 77984 status New Under Review 02/28/23, 18:14

  3. Gerrit Code Review pushed patch set 2 for main to change 77984 02/28/23, 18:22

  4. Simon Schaufelberger changed Related to #99926 03/01/23, 00:03

  5. Gerrit Code Review pushed patch set 3 for main to change 77984 03/01/23, 05:04

  6. Gerrit Code Review pushed patch set 4 for main to change 77984 03/01/23, 10:08

  7. Gerrit Code Review pushed patch set 5 for main to change 77984 03/01/23, 10:15

  8. Gerrit Code Review pushed patch set 1 for 11.5 to change 77991 03/01/23, 11:56

  9. Thomas Hohn commented and changed status Under Review Resolved done 0 % 100 % 03/01/23, 12:15

    Applied in changeset commit:86d1f36c7ca2bcef3316dd1008603441fa23a534.

  10. Benni Mack changed status Resolved Closed 01/30/24, 09:06