Review main Merged

78016[TASK] Open up Expression Resolver API

Helmut Hummel CR +2 V +2 Normal +45 −16 updated 03/08/23, 07:24

Commit message

The Symfony Expression language is able to evaluate
any value from an expression, not only booleans.
Open up TYPO3 wrapper API to reflect this, to allow
extended usage of our API wrapper.

Instead of only allowing boolean returns, the caller of
the Resolver API is now responsible for casting the result
of the expression to bool, if required.

Also allow to pass additional context specific variables
to the evaluate function, as it is not always possible
to provide those through a global API, when some context
is only available at the time of the evaluation of the expression.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Helmut Hummel uploaded patch set 1 03/03/23, 15:09

  2. core-ci voted on patch set 1 V -1 03/03/23, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38364

  3. Helmut Hummel uploaded patch set 2 V -1 03/04/23, 10:20

  4. core-ci voted on patch set 2 V +1 03/04/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38429

  5. Alexander Schnitzler voted on patch set 2 V +1 CR +1 03/04/23, 12:20

  6. Benni Mack voted on patch set 2 V +2 CR +2 03/06/23, 09:03

  7. Benni Mack merged patch set 3 03/06/23, 09:03

  8. Helmut Hummel commented on patch set 3 03/08/23, 07:24

    Uh, nice! Thanks for the quick reviews and merge. I should have unstashed this change much earlier ;)