Review 11.5 Merged

78054[TASK] Update to PHPStan 1.10.6

Oliver Klee CR +2 V +2 Easy +16 −21 updated 03/09/23, 19:10

Commit message

This version removes some false positives from the baseline.

> composer req --dev phpstan/phpstan:^1.10.6
> composer req --dev phpstan/phpstan-phpunit:^1.3.10
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Oliver Klee commented on patch set 1 03/09/23, 18:32

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock
  2. core-ci voted on patch set 1 V -1 03/09/23, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38716

  3. Oliver Klee uploaded patch set 2 V -1 03/09/23, 18:35

  4. Oliver Klee commented on patch set 2 03/09/23, 18:36

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 03/09/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38717

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 03/09/23, 19:10

  7. Anja Leichsenring merged patch set 3 03/09/23, 19:10