Review main Merged

78087[BUGFIX] Render mime type audio/x-wav as audio file

Georg Ringer CR +2 V +2 Easy +1 −1 updated 05/03/23, 09:37

Commit message

The mime type 'audio/x-wav' must be added to the AudioTagRenderer to
render those files as audio file.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • abohn_hebotek +1
    • Oliver Klee +1
    • Guido Schmechel +1
    • Florian Heder +1
  • Verified V +2 Done
    • Benni Mack +2
    • abohn_hebotek +1
    • Guido Schmechel +1
    • Florian Heder +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1315

  1. Georg Ringer uploaded patch set 1 03/10/23, 09:55

  2. Georg Ringer commented on patch set 1 03/10/23, 09:55

    This change is ready for review.
  3. Georg Ringer updated the commit message in patch set 2 03/10/23, 09:57

  4. core-ci voted on patch set 2 V +1 03/10/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38761

  5. Oliver Klee voted on patch set 2 CR +1 03/10/23, 10:17

  6. core-ci voted on patch set 1 V +1 03/10/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38760

  7. Benni Mack voted on patch set 2 V +1 CR +1 03/10/23, 12:28

  8. abohn_hebotek voted on patch set 2 CR +1 03/10/23, 14:27

  9. Markus Klein commented on patch set 2 CR -1 03/10/23, 14:30

    https://mimetype.io/audio/x-wav This type has been deprecated in favor of one of it's alternatives.
  10. Markus Klein commented on patch set 2 CR 0 03/10/23, 14:33

    Removing my -1. I'm not blocking this, but please give it a second thought, whether we wanna add old mime-types? See also forge issue.
  11. abohn_hebotek voted on patch set 2 V +1 03/10/23, 14:37

  12. Florian Heder commented on patch set 2 V +1 CR +1 03/17/23, 10:43

    It is still recommended to support it.
  13. Guido Schmechel voted on patch set 2 V +1 CR +1 03/18/23, 11:58

  14. Benni Mack voted on patch set 2 V +2 CR +2 05/03/23, 09:37

  15. Benni Mack merged patch set 3 05/03/23, 09:37