Issue Bug Closed

#100138audio wav with mime type audio/x-wav is not recognized as audio file

Alexander Bohn 03/10/23, 08:40 updated 07/09/24, 12:46

Description

audio/wav -> HTML Audio Tag is correctly rendered
audio/x-wav -> Img Tag is rendered

after changing the sys_file/myme_type from audio/x-wav to audio/wav it is working.

Reviews 2

History 811

  1. Gerrit Code Review pushed patch set 1 for main to change 78087 status New Under Review 03/10/23, 09:55

  2. Georg Ringer commented 03/10/23, 09:56

    changed it in the AudioTagRenderer to protected $possibleMimeTypes = ['audio/mpeg', 'audio/wav', 'audio/x-wav', 'audio/ogg'];

    maybe you wanna review the change in gerrit?

  3. Gerrit Code Review pushed patch set 2 for main to change 78087 03/10/23, 09:57

  4. Markus Klein commented 03/10/23, 14:32

    Question is, where does this mime-type come from?

    https://mimetype.io/audio/x-wav
    says it’s deprecated.

  5. Floyd Hermes commented 03/17/23, 10:31

    Thank you for the additional information which states “you should likely still support it”.

    As it is needed, it is super easy to implement, it has no side effects and it is recommend it to support it – we should add the mime type to the cms.

  6. Markus Klein commented 04/26/23, 10:01

    Would you mind answering my last question?

    > Question is, where does this mime-type come from?

    What are you doing such that the system identifies a file as audio/x-wav?
    Any outdated mime-type detection going on?

    I’d like to understand how the problem is rooted.

  7. Alexander Bohn commented 04/27/23, 06:25

    > Question is, where does this mime-type come from?

    That´s what the customer told me:

    I also looked into where the mime-type comes from (different browsers on Mac and Windows), but couldn’t figure out why it’s set to x-wav. According to the StackOverflow article, Chrome (or Chromium) and Firefox either set it themselves or the operating system sets it when uploading (I also found x-wav in the Windows registry). I haven’t had time to try Linux yet.

  8. Markus Klein commented 04/27/23, 07:06

    Thanks. my question was a bit misleading. The mimetype is usually determined by the server of course. I meant: Which library on the server does the mimetype detection?
    I assume this is simply outdated there. I understand, though, that this might not be changeable any time soon.

    Note: If the mime-type sent by the client would be trusted, this would be very insecure.

  9. Gerrit Code Review pushed patch set 1 for 11.5 to change 78894 05/03/23, 09:37

  10. Georg Ringer commented and changed status Under Review Resolved done 0 % 100 % 05/03/23, 09:40

    Applied in changeset commit:bc60401fc660148e76f1d5a47dfaba8d329eb147.

  11. Benni Mack changed status Resolved Closed 07/09/24, 12:46