Review main Merged

78282[BUGFIX] Re-introduce SQL query per page during menu generation

Christoph Lehmann CR +2 V +2 Easy +20 −11 updated 04/27/23, 15:52

Commit message

With the Bugfix #100188 an integer is compared type-safe with a string:

$page['uid'] ?? false) !== $linkDetails['pageuid']

This makes sure

* $linkDetails['pageuid'] is an integer if possible
* The tests use assertSame instead assertEqual for type safe comparison

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2029

Show 34 earlier messages
  1. Christoph Lehmann uploaded patch set 1 03/27/23, 21:48

  2. Christoph Lehmann updated the commit message in patch set 2 03/27/23, 21:55

  3. core-ci voted on patch set 1 V +1 03/27/23, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39734

  4. Oliver Klee commented on patch set 2 03/27/23, 21:58

    I propose we cover this bug with a regression test.
  1. core-ci voted on patch set 2 V +1 03/27/23, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39735

  2. Benni Mack voted on patch set 2 V +1 CR +1 03/28/23, 06:59

  3. Benni Mack commented on patch set 2 03/28/23, 07:00

    Reply

    I think the regression test should work in another place, and in order to have this in the release today, Christoph, can you add a test until LTS?
  4. Benni Mack commented on patch set 2 V 0 CR -1 03/28/23, 07:02

    I guess we also need to address this in another place.
  5. Christoph Lehmann uploaded patch set 3 CR -1 V +1 04/01/23, 19:56

  6. Christoph Lehmann uploaded patch set 4 04/01/23, 20:00

  7. Christoph Lehmann commented on patch set 4 04/01/23, 20:08

    Reply

    I introduced strict type comparison in the tests where pageuid and pagetype is checked

    PageLinkHandlerTest.php:50

    Even if input is a string, pageuid should be converted to an integer
  8. core-ci voted on patch set 3 V -1 04/01/23, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39943

  9. core-ci voted on patch set 4 V -1 04/01/23, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39944

  10. Christoph Lehmann uploaded patch set 5 V -1 04/02/23, 13:46

  11. core-ci voted on patch set 5 V +1 04/02/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39982

  12. Oliver Klee updated the commit message in patch set 6 V +1 04/02/23, 14:35

  13. core-ci voted on patch set 6 V +1 04/02/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39991

  14. Christoph Lehmann uploaded patch set 7 V +1 04/10/23, 20:18

  15. Christoph Lehmann uploaded patch set 8 04/10/23, 20:25

  16. core-ci voted on patch set 7 V +1 04/10/23, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40426

  17. core-ci voted on patch set 8 V +1 04/10/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40429

  18. Benni Mack uploaded patch set 9 V +1 04/20/23, 14:56

  19. Benni Mack commented on patch set 9 CR +1 04/20/23, 14:56

    I did not cast pagetype to int as this might have side-effects also during resolving (PageArguments has argument $pageType explicitly as string)
  20. core-ci voted on patch set 9 V +1 04/20/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40984

  21. Georg Ringer voted on patch set 9 V +1 CR +1 04/20/23, 18:37

  22. Benni Mack voted on patch set 9 V +2 CR +2 04/20/23, 19:29

  23. Benni Mack merged patch set 10 04/20/23, 19:29

  24. Oli Bartsch commented on patch set 10 04/21/23, 09:55

    Post -1. This currently breaks the TargetPageIdViewHelper
  25. Oli Bartsch commented on patch set 10 04/27/23, 15:52