78282[BUGFIX] Re-introduce SQL query per page during menu generation
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2029
Show 34 earlier messages
-
Christoph Lehmann uploaded patch set 1 03/27/23, 21:48
-
Christoph Lehmann updated the commit message in patch set 2 03/27/23, 21:55
-
core-ci voted on patch set 1 V +1 03/27/23, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39734
-
Oliver Klee commented on patch set 2 03/27/23, 21:58
I propose we cover this bug with a regression test.
-
core-ci voted on patch set 2 V +1 03/27/23, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39735
-
Benni Mack voted on patch set 2 V +1 CR +1 03/28/23, 06:59
-
Benni Mack commented on patch set 2 03/28/23, 07:00
Reply
I think the regression test should work in another place, and in order to have this in the release today, Christoph, can you add a test until LTS? -
Benni Mack commented on patch set 2 V 0 CR -1 03/28/23, 07:02
I guess we also need to address this in another place. -
Christoph Lehmann uploaded patch set 3
CR -1V +104/01/23, 19:56 -
Christoph Lehmann uploaded patch set 4 04/01/23, 20:00
-
Christoph Lehmann commented on patch set 4 04/01/23, 20:08
Reply
I introduced strict type comparison in the tests where pageuid and pagetype is checkedPageLinkHandlerTest.php:50Even if input is a string, pageuid should be converted to an integer -
core-ci voted on patch set 3 V -1 04/01/23, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39943
-
core-ci voted on patch set 4 V -1 04/01/23, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39944
-
Christoph Lehmann uploaded patch set 5
V -104/02/23, 13:46 -
core-ci voted on patch set 5 V +1 04/02/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39982
-
Oliver Klee updated the commit message in patch set 6
V +104/02/23, 14:35 -
core-ci voted on patch set 6 V +1 04/02/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39991
-
Christoph Lehmann uploaded patch set 7
V +104/10/23, 20:18 -
Christoph Lehmann uploaded patch set 8 04/10/23, 20:25
-
core-ci voted on patch set 7 V +1 04/10/23, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40426
-
core-ci voted on patch set 8 V +1 04/10/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40429
-
Benni Mack uploaded patch set 9
V +104/20/23, 14:56 -
Benni Mack commented on patch set 9 CR +1 04/20/23, 14:56
I did not cast pagetype to int as this might have side-effects also during resolving (PageArguments has argument $pageType explicitly as string) -
core-ci voted on patch set 9 V +1 04/20/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40984
-
Georg Ringer voted on patch set 9 V +1 CR +1 04/20/23, 18:37
-
Benni Mack voted on patch set 9 V +2 CR +2 04/20/23, 19:29
-
Benni Mack merged patch set 10 04/20/23, 19:29
-
Oli Bartsch commented on patch set 10 04/21/23, 09:55
Post -1. This currently breaks the TargetPageIdViewHelper -
Oli Bartsch commented on patch set 10 04/27/23, 15:52
Reply