Review main Merged

78543[BUGFIX] Finetune table-fit border removals

Benjamin Kott CR +2 V +2 Easy +23 −3 updated 04/11/23, 07:27

Commit message

To avoid double borders at the bottom for tables in
a .table-fit wrapper the default border-bottom, for
the last row is removed.

The current version forgot to consider that there can be
multiple tbody or tfoot. The selector is now adjusted to
consider this.

For bordered tables, a double border appeared at the top,
this one is now also correctly removed. Captions are now
supported in a .table-fit wrapper and placed correctly.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Benjamin Kott uploaded patch set 1 04/08/23, 07:46

  2. core-ci voted on patch set 1 V +1 04/08/23, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40363

  3. Benjamin Kott uploaded patch set 2 V +1 04/08/23, 08:45

  4. core-ci voted on patch set 2 V +1 04/08/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40365

  5. Markus Klein updated the commit message in patch set 3 V +1 04/08/23, 13:45

  6. Markus Klein voted on patch set 3 V +1 CR +1 04/08/23, 13:45

  7. core-ci voted on patch set 3 V +1 04/08/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40374

  8. Andreas Kienast voted on patch set 3 V +2 CR +2 04/11/23, 07:27

  9. Andreas Kienast merged patch set 4 04/11/23, 07:27