Issue Bug Closed

#100533Restrict table-fit last-row border removal

Benjamin Kott 04/08/23, 07:44 updated 07/09/24, 12:55

Description

No description.

Reviews 1

Files 4

History 811

  1. Gerrit Code Review pushed patch set 1 for main to change 78543 status New Under Review 04/08/23, 07:46

  2. Benjamin Kott changed attached borders-current.png attached borders-desired.png 04/08/23, 07:48

  3. Gerrit Code Review pushed patch set 2 for main to change 78543 04/08/23, 08:45

  4. Benjamin Kott changed borders-current.png 04/08/23, 08:52

  5. Benjamin Kott changed borders-desired.png 04/08/23, 08:52

  6. Benjamin Kott changed attached tables-bordered-after.png attached tables-after.png 04/08/23, 08:52

  7. Benjamin Kott changed attached tables-bordered-before.png attached tables-before.png 04/08/23, 08:55

  8. Benjamin Kott commented 04/08/23, 08:56

    Test Markup

    <div class="p-5">
        <h2>Table</h2>
        <div class="table-fit">
            <table class="table table-hover">
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
            </table>
        </div>
    
        <h2>Table with caption</h2>
        <div class="table-fit">
            <table class="table table-hover">
                <caption>List of users</caption>
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
            </table>
        </div>
    
        <h2>Table with caption top</h2>
        <div class="table-fit">
            <table class="table table-hover caption-top">
                <caption>List of users</caption>
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
            </table>
        </div>
    
        <h2>Table with footer</h2>
        <div class="table-fit">
            <table class="table table-hover">
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
                <tfoot>
                    <tr>
                        <th colspan="4">FOOTER</th>
                    </tr>
                </tfoot>
            </table>
        </div>
    
        <h2>Table with footer and caption</h2>
        <div class="table-fit">
            <table class="table table-hover">
                <caption>List of users</caption>
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
                <tfoot>
                    <tr>
                        <th colspan="4">FOOTER</th>
                    </tr>
                </tfoot>
            </table>
        </div>
    </div>
    
    <hr>
    
    <div class="p-5">
        <h2>Table bordered</h2>
        <div class="table-fit">
            <table class="table table-bordered table-hover">
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
            </table>
        </div>
    
        <h2>Table bordered with caption</h2>
        <div class="table-fit">
            <table class="table table-bordered table-hover">
                <caption>List of users</caption>
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
            </table>
        </div>
    
        <h2>Table bordered with caption top</h2>
        <div class="table-fit">
            <table class="table table-bordered table-hover caption-top">
                <caption>List of users</caption>
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
            </table>
        </div>
    
        <h2>Table bordered with footer</h2>
        <div class="table-fit">
            <table class="table table-bordered table-hover">
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
                <tfoot>
                    <tr>
                        <th colspan="4">FOOTER</th>
                    </tr>
                </tfoot>
            </table>
        </div>
    
        <h2>Table bordered with footer and caption</h2>
        <div class="table-fit">
            <table class="table table-bordered table-hover">
                <caption>List of users</caption>
                <thead>
                    <tr>
                        <th scope="col">#</th>
                        <th scope="col">First</th>
                        <th scope="col">Last</th>
                        <th scope="col">Handle</th>
                    </tr>
                </thead>
                <tbody>
                    <tr>
                        <th scope="row">1</th>
                        <td>Benjamin</td>
                        <td>Kott</td>
                        <td>@benjaminkott</td>
                    </tr>
                    <tr>
                        <th scope="row">2</th>
                        <td>TYPO3</td>
                        <td></td>
                        <td>@typo3</td>
                    </tr>
                </tbody>
                <tfoot>
                    <tr>
                        <th colspan="4">FOOTER</th>
                    </tr>
                </tfoot>
            </table>
        </div>
    </div>
  9. Gerrit Code Review pushed patch set 3 for main to change 78543 04/08/23, 13:45

  10. Benjamin Kott commented and changed status Under Review Resolved done 0 % 100 % 04/11/23, 07:30

    Applied in changeset commit:83f2d8e734fad40553f6504bc54c6d962b1fe3c8.

  11. Benni Mack changed status Resolved Closed 07/09/24, 12:55