Review main Merged

78646[BUGFIX] Allow to render figure tags in RTE elements

Benni Mack CR +2 V +2 Easy +1 −1 updated 04/17/23, 08:47

Commit message

With CKeditor table elements are in RTE fields now
for tables, however, they need to be added to parseFunc
as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Benni Mack uploaded patch set 1 04/14/23, 21:34

  2. core-ci voted on patch set 1 V +1 04/14/23, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40647

  3. Oliver Klee voted on patch set 1 CR +1 04/15/23, 09:00

  4. Tobias Wollender commented on patch set 1 04/15/23, 15:23

    Shouldn't this text be about the figure tag?
  5. Tobias Wollender commented on patch set 1 04/15/23, 15:27

    Ok, just found out that figure can also be around tables, not just images. So the description makes more sense now.

    Reply

    Done
  6. Jörg Bösche voted on patch set 1 CR +1 04/17/23, 07:38

  7. Oli Bartsch voted on patch set 1 V +1 CR +1 04/17/23, 08:31

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 04/17/23, 08:47

  9. Christian Kuhn merged patch set 2 04/17/23, 08:47