Review 11.5 Merged

78732[BUGFIX] Prevent type errors in ExportController

Benni Mack CR +2 V +2 Easy +5 −3 updated 03/20/24, 06:14

Commit message

In case an export is created based on e.g.
an invalid preset, no PHP TypeError should
occur.

This is now fixed by properly typecasting
the input data.

Additionally, two possible undefined array
key access warnings are fixed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Benni Mack commented on patch set 1 04/18/23, 12:34

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/impexp/Classes/Controller/ExportController.php
  2. Benni Mack commented on patch set 2 04/18/23, 12:36

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 04/18/23, 12:36

  4. Oliver Klee voted on patch set 2 CR +1 04/18/23, 12:42

  5. core-ci voted on patch set 2 V +1 04/18/23, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40872

  6. Benni Mack voted on patch set 2 V +2 CR +2 04/18/23, 12:58

  7. Benni Mack merged patch set 3 04/18/23, 12:58

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 04/18/23, 12:58