Review 11.5 Merged

78736[BUGFIX] Ensure AbstractExceptionHandler::IGNORED_EXCEPTION_CODES is protected

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 04/24/23, 19:33

Commit message

With #100720 the AbstractExceptionHandlers
const IGNORED_EXCEPTION_CODES was set from private
to public in order to allow to use it in subclasses.

However, public is making this a full public API,
which should be within the ExceptionHandler logic
in general.

For this reason, the constant is now changed from
public to protected.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 04/24/23, 19:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/24/23, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41191

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 04/24/23, 19:33

  4. Stefan Bürk merged patch set 2 04/24/23, 19:33