Review 12.4 Merged

79126[BUGFIX] Fix phpstan finding in Clipboard

Nikita Hovratov CR +2 V +2 Easy +4 −9 updated 06/01/23, 10:19

Commit message

The parent folder could theoretically be an InaccessibleFolder
according to the return type annotation, but only Folder has the method
"getCombinedIdentifier".

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Nikita Hovratov commented on patch set 1 06/01/23, 10:00

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/01/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42142

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 06/01/23, 10:19

  4. Nikita Hovratov merged patch set 2 06/01/23, 10:19