Review 12.4 Merged

79174[TASK] Slim down php-cs-fixer configuration file

Stefan Bürk CR +2 V +2 Easy +3 −11 updated 06/05/23, 18:58

Commit message

TYPO3 uses PER standard definitions and some more additions
when it comes to PHP Coding guidelines.

However, the main config file of TYPO3 defines some configuration
options which are already in PSR-12 RuleSet (which is the current PER definition)
see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.17.0/src/RuleSet/Sets/PSR12Set.php
which can be removed.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 06/05/23, 18:50

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/05/23, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42222

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 06/05/23, 18:58

  4. Stefan Bürk merged patch set 2 06/05/23, 18:58