Review 12.4 Merged

79354[BUGFIX] DatabaseUpdatedPrerequisite returns correct ensure-state

Stefan Bürk CR +2 V +2 Easy +9 −5 updated 06/14/23, 12:23

Commit message

The `ensure` method must return true,
if all operations were successful.

This is the case if all database
operations succeeded without returning
an error message.

The error messages are now checked
correctly and the corresponding state
is returned.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 06/14/23, 12:14

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/14/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42544

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 06/14/23, 12:23

  4. Stefan Bürk merged patch set 2 06/14/23, 12:23