Review 12.4 Merged

79542[BUGFIX] Set locale for FormatSize

Benni Mack CR +2 V +2 Easy +7 −0 updated 07/03/23, 13:42

Commit message

As LC_NUMERIC is not set via Locales::setLocale
because conflicts on float calculation may occur,
we have to manually set LC_NUMERIC in places where
we need the locale aware numeric functionality.

In the core this is only formatSize - which missed
the LC_NUMERIC handling since the switch to
SiteConfiguration. With this patch, the handling is
reintroduced by using the locale set by setLocale for
LC_MONETARY to temporarily set LC_NUMERIC in formatSize.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 07/03/23, 13:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/03/23, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43233

  3. Benni Mack voted on patch set 1 V +2 CR +2 07/03/23, 13:42

  4. Benni Mack merged patch set 2 07/03/23, 13:42