79638[BUGFIX] Enable additional attributes for Media ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php3+8 −2
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+15 −0
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+15 −8
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/Link/FileViewHelper/Folders/fileadmin/user_upload/example.mp4newbinary
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/MediaViewHelperTest.phpnew+65 −0
Review log 67
-
Benni Mack commented on patch set 1 07/03/23, 19:53
Cherry Picked from branch main. -
Benni Mack rebased onto patch set 2 07/04/23, 07:15
-
core-ci voted on patch set 2 V +1 07/04/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43333
-
Andreas Kienast commented on patch set 2 07/04/23, 07:29
VideoTagRenderer.php:111I think we should enforce a string cast here. -
Benni Mack commented on patch set 2 V +2 CR +2 07/04/23, 07:31
VideoTagRenderer.php:111Replysorry, won't do this in a backport -
Benni Mack merged patch set 3 07/04/23, 07:31
-
Benni Mack commented on patch set 3 07/04/23, 09:38
VideoTagRenderer.php:111ReplyDone