Review 12.4 Merged

79638[BUGFIX] Enable additional attributes for Media ViewHelper

Benni Mack CR +2 V +2 Normal +103 −10 updated 07/04/23, 09:38

Commit message

This change also adds some basic tests for MediaViewHelper

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 67

  1. Benni Mack commented on patch set 1 07/03/23, 19:53

    Cherry Picked from branch main.
  2. Benni Mack rebased onto patch set 2 07/04/23, 07:15

  3. core-ci voted on patch set 2 V +1 07/04/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43333

  4. Andreas Kienast commented on patch set 2 07/04/23, 07:29

    VideoTagRenderer.php:111

    I think we should enforce a string cast here.
  5. Benni Mack commented on patch set 2 V +2 CR +2 07/04/23, 07:31

    VideoTagRenderer.php:111 Reply

    sorry, won't do this in a backport
  6. Benni Mack merged patch set 3 07/04/23, 07:31

  7. Benni Mack commented on patch set 3 07/04/23, 09:38

    VideoTagRenderer.php:111 Reply

    Done