Review 12.4 Merged

79690[BUGFIX] Add read_only to cache identifier for file mounts

Stefan Bürk CR +2 V +2 Easy +26 −9 updated 07/05/23, 12:31

Commit message

The cache identifier for file mounts only consisted of storage id
and path. In rare cases (with same name file mounts with different
read-only settings) this lead to rendering an arbitrary folder instead
of the mount with the "higher" access rights.

The read_only field is now taken into account when generating the
runtime cache identifier.

The file module already takes care of using the write file mount if
both read-only and not read-only exist.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Stefan Bürk commented on patch set 1 07/05/23, 12:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/05/23, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43502

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/05/23, 12:31

  4. Stefan Bürk merged patch set 2 07/05/23, 12:31