Review 12.4 Merged

79813[BUGFIX] Check default language for preview requirements

Andreas Kienast CR +2 V +2 Easy +13 −4 updated 07/06/23, 12:37

Commit message

When previewing a translated page that is enabled which has
a parent (default lang) page that is hidden, users got a 403
error, because the preview flag was not set (as the page itself
was not hidden).

Change the check to always check both the default language and
the overlay for setting the preview flag.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Andreas Kienast commented on patch set 1 07/06/23, 11:41

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 07/06/23, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43709

  3. Benni Mack rebased onto patch set 2 V -1 07/06/23, 11:57

  4. core-ci voted on patch set 2 V +1 07/06/23, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43715

  5. Benni Mack voted on patch set 2 V +2 CR +2 07/06/23, 12:37

  6. Benni Mack merged patch set 3 07/06/23, 12:37