Review 12.4 Merged

79826[BUGFIX] Render only one toggle per node in trees

Benni Mack CR +2 V +2 Normal +70 −45 updated 07/06/23, 17:39

Commit message

In non-SVG trees, there are currently two icons representing the node's
expansion state rendered that get toggled via CSS rules based on
hard-coded aria attributes and icon identifiers, which is a bad
practice.

To solve this, a new web component `typo3-backend-tree-node-toggle` is
added whose only responsibility is to render the correct icon based on
its `aria-expanded` attribute

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 12

Review log 34

  1. Benni Mack commented on patch set 1 07/06/23, 17:26

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/06/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43782

  3. Benni Mack voted on patch set 1 V +2 CR +2 07/06/23, 17:39

  4. Benni Mack merged patch set 2 07/06/23, 17:39