Review 12.4 Merged

79985[BUGFIX] Do not store bollocks markup in icon cache

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 07/13/23, 06:18

Commit message

In very rare cases it may happen that a backend session is not valid
anymore when an icon is loaded within the TYPO3 backend. If the icon
is not in the user's localStorage, the TYPO3 backend login is stored
in localStorage instead.

To catch this issue in the future, additional checks were implemented:

* the response shall not come from a redirected request, which could be
  an indicator for unwanted markup
* the received markup must start with "<span"

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 07/13/23, 05:55

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/13/23, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44105

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 07/13/23, 06:18

  4. Andreas Kienast merged patch set 2 07/13/23, 06:18