Review 12.4 Merged

80054[BUGFIX] Avoid exception in redirects module

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 07/17/23, 16:00

Commit message

In redirects module it is possible to configure redirects
to records available through the LinkHandler API. This currently
fails with an exception, since the redirects module tries to
resolve the link to the record in the list view. The reason for
this is the `DatabaseRecordLinkBuilder`, which uses the
`frontend.typoscript` attribute from the request object to
retrieve the TypoScript setup. This attribute is not available
in backend context.

This change ensures that the `$typoScriptArray` will fall back
to an empty array if the `frontend.typoscript` request attribute
is not available.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 07/17/23, 15:50

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/17/23, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44216

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/17/23, 15:59

  4. Stefan Bürk merged patch set 2 07/17/23, 16:00