Review 12.4 Merged

80055[BUGFIX] Pass current rendarable context to condition evaluation

Stefan Bürk CR +2 V +2 Easy +37 −2 updated 07/18/23, 08:37

Commit message

Form elements are represented by PHP objects,
which hold some state, which can be modified during form runtime.

However it is impossible to access this state in a variant condition,
because the instance of the current element is not passed
to the expression language evaluation.

The current renderable is now passed as additional
variable to the condition evaluation.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Stefan Bürk commented on patch set 1 07/18/23, 08:29

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/18/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44235

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/18/23, 08:37

  4. Stefan Bürk merged patch set 2 07/18/23, 08:37