Review 12.4 Merged

80058[BUGFIX] Fix fallback icons for custom page types

Nikita Hovratov CR +2 V +2 Easy +3 −3 updated 07/18/23, 15:15

Commit message

Since the introduction of customizable page type icons,
the fallback icons did no longer work. Only the icon
and variations for "contentFromPid" worked. The reason
is, that these icons are prefixed with "page" while the
other ones are prefixed with the doktype ("1").

This is fixed now by providing an optional argument
for the getRecordTypeForPageType method, which takes
the type name as parameter. The default is "1".

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Nikita Hovratov commented on patch set 1 07/18/23, 14:52

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/18/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44263

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 07/18/23, 15:15

  4. Nikita Hovratov merged patch set 2 07/18/23, 15:15