Review 12.4 Merged

80061[BUGFIX] Fix incorrect type in RouteDispatcherTest

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 07/18/23, 19:04

Commit message

A route option that is missing should either not be set at all, or
it should be `null`, but it will never be `false`.

Simplify the test by removing the missing option altogether to make the
test more minimal.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Nikita Hovratov commented on patch set 1 07/18/23, 18:49

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/18/23, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44279

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 07/18/23, 19:04

  4. Nikita Hovratov merged patch set 2 07/18/23, 19:04