Review 12.4 Merged

80148[TASK] Remove superfluous language service usage in ext:install

Christian Kuhn CR +2 V +2 Easy +0 −4 updated 07/28/23, 07:53

Commit message

The usage of `LanguageServiceFactory` in `SetupDatabaseService`
can safely be removed, since it is not required to initialize
`$GLOBALS['LANG']` in order to localize password policy validation
messages.

Since #97390 the `AbstractPasswordValidator` takes care of initializing
the `LanguageService` and localizes possible password policy validation
error messages.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 07/28/23, 06:14

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/28/23, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44640

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 07/28/23, 07:53

  4. Christian Kuhn merged patch set 2 07/28/23, 07:53