Review 12.4 Merged

80151[BUGFIX] Fix return type annotation for GU::explodeUrl2Array

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/28/23, 08:13

Commit message

PHP silently converts array keys that are int-like strings to ints.
We need to reflect this in our type annotations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn commented on patch set 1 07/28/23, 07:56

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 07/28/23, 07:58

  3. core-ci voted on patch set 1 V +1 07/28/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44656

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 07/28/23, 08:13

  5. Christian Kuhn merged patch set 2 07/28/23, 08:13