Review 12.4 Merged

80361[BUGFIX] Don't notify the editor about canceled SvgTree Ajax request

Andreas Kienast CR +2 V +2 Easy +29 −2 updated 08/05/23, 20:42

Commit message

If the svg-tree component is embedded in an iframe,
and if the iframe src get changed by navigating to another url,
pending AjaxRequest will be cancelled by the browser,
without letting us the opportunity to properly catch the thrown error.

As a workaround, we register an unload event on the iframe's window,
and mute notifications to the user.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Andreas Kienast commented on patch set 1 08/05/23, 20:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 08/05/23, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45120

  3. Andreas Kienast uploaded patch set 2 V -1 08/05/23, 20:32

  4. core-ci voted on patch set 2 V +1 08/05/23, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45126

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 08/05/23, 20:42

  6. Andreas Kienast merged patch set 3 08/05/23, 20:42