80536[TASK] Add target for live search links
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/80536/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/80536/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 7
- main 94015[FEATURE] Rank live search results by relevance
- main 95436[WIP][TASK] Initialise class properties across the JavaScript stack
- main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build
- main 97458[TASK] Update htmlnano to v3 and litnano to v1.1
- main 92257[WIP] Toolbar
- main 91683[WIP][TASK] Move live search related labels
- main 84809[WIP][BUGFIX|TASK|FEATURE] Make live search result list accessible by screenreader
Issues 1
Files 7
- Build/Sources/TypeScript/backend/live-search/element/result/item/action/action-container.ts+1 −1
- Build/Sources/TypeScript/backend/live-search/element/result/item/item.ts+1 −0
- Build/Sources/TypeScript/backend/live-search/element/result/result-container.ts+5 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/ResultItemAction.php+14 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result/item/action/action-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result/result-container.js+1 −1
- typo3/sysext/backend/Tests/Unit/Search/LiveSearch/ResultItemActionTest.phpnew+66 −0
Review log 913
-
Guido Schmechel uploaded patch set 1 08/12/23, 20:47
-
core-ci voted on patch set 1 V +1 08/12/23, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45426
-
Benni Mack updated the commit message in patch set 2
V +110/18/24, 14:11 -
Andreas Kienast commented on patch set 2 CR -1 01/09/25, 11:22
I like the idea, but that won't work. Clicking a search item action invokes the event `livesearch:invoke-action`, which is handled in `@typo3/backend/live-search/element/result/result-container.ts`. This event handler expects a custom action handler, which may open a new window (to reflect the hypothetical scenario in your issue). If no custom action handler is given, it falls backs to opening the URL in the content frame. -
Guido Schmechel commented on patch set 2 01/10/25, 14:53
Reply
Is there even a realistic chance of implementing such a feature? Or should we set the patch to Abandon? -
Andreas Kienast commented on patch set 2 01/10/25, 14:57
Reply
I have to think about this in a broader scope. -
Andreas Kienast uploaded patch set 3
CR -101/21/25, 15:13 -
core-ci voted on patch set 3 V +1 01/21/25, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72792
-
Guido Schmechel commented on patch set 3 CR +1 V +1 02/02/25, 12:57
I was so free and give +1 for the change of Andreas, even if the initial patch was created by me. Tested with an own DictionaryProvider. Example: https://github.com/ayacoo/examplesearch/blob/v14/Classes/LiveSearch/DictionaryProvider.php -
Benni Mack updated the commit message in patch set 4
CR +1V +104/22/26, 06:30 -
core-ci voted on patch set 4 V -1 04/22/26, 07:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100712
-
Georg Ringer uploaded patch set 5
V -109/15/26, 19:29 -
core-ci voted on patch set 5 V +1 09/15/26, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108637