Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress

95436[WIP][TASK] Initialise class properties across the JavaScript stack

Benjamin Kott CR 0 V 0 Hard +275 −275 updated 11/18/26, 11:31

Commit message

Give every class property either an initial value or a definite
assignment assertion, so that strictPropertyInitialization no longer
reports it. Which of the two applies follows the pattern the stack
already establishes.

Reactive properties declared with @property or @state receive a
default, the form nearly all existing declarations already use.
Element references obtained through
@query, @queryAll or @queryAssignedElements receive an assertion,
because the decorator installs a getter and never assigns the field.
Plain properties receive an assertion wherever the class demonstrably
assigns them outside the constructor.

Two properties are declared honestly instead. Wizard.submissionService
is checked for truthiness before it is used, so it now carries
undefined in its type rather than an assertion the surrounding code
contradicts, in the wizard and in the four elements that host it.
TsParser.global is only ever written, never read, and starts out
false.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 8
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/95436/8 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/95436/8 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 13

  1. main 95437[WIP][TASK] Enable strict mode for the TypeScript build Based on this change Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Easy +1 −9
  2. 95436 [WIP][TASK] Initialise class properties across the JavaScript stack This change

  3. main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build This change is based on it Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Nightmare +1822 −1817
  4. main 95434[WIP][TASK] Clear the last strictNullChecks errors in the backend This change is based on it Work in progress Merge conflict Benjamin Kott CR 0 V -1 → 14.3 Normal +66 −60
  5. main 95433[WIP][TASK] Reduce the remaining backend strictNullChecks errors This change is based on it Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Normal +63 −59
  6. main 95432[WIP][TASK] Carry the backend further towards strictNullChecks This change is based on it Work in progress Merge conflict Benjamin Kott CR 0 V 0 → 14.3 Normal +57 −45
  7. main 95431[TASK] Make most of the backend TypeScript null-safe This change is based on it Benjamin Kott CR 0 V 0 → 14.3 Hard +204 −199

    The chain has patch set 8 of 10, the changes above it need a rebase.

  8. main 95430[TASK] Make the form editor null-safe This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Normal +91 −84

    The chain has patch set 8 of 10, the changes above it need a rebase.

  9. main 95429[TASK] Make the install tool null-safe This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Normal +99 −93

    The chain has patch set 8 of 10, the changes above it need a rebase.

  10. main 95428[TASK] Make the file list and the RTE null-safe This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Normal +119 −111

    The chain has patch set 8 of 10, the changes above it need a rebase.

  11. main 95427[TASK] Make the dashboard null-safe This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Normal +135 −70

    The chain has patch set 8 of 10, the changes above it need a rebase.

  12. main 95426[TASK] Guard nullable values in backend modules This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Hard +147 −123

    The chain has patch set 8 of 9, the changes above it need a rebase.

  13. main 95425[TASK] Guard nullable values in TypeScript This change is based on it Merged Benjamin Kott CR +2 V +2 → 14.3 Hard +307 −276

    The chain has patch set 8 of 10, the changes above it need a rebase.

Files 152

Show 132 more files

Review log 917

  1. Benjamin Kott uploaded patch set 1 08/26/26, 13:09

  2. Benjamin Kott marked it work in progress 08/26/26, 13:24

  3. core-ci voted on patch set 1 V +1 08/26/26, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107149

  4. Benjamin Kott uploaded patch set 2 V +1 10/15/26, 16:16

  5. core-ci voted on patch set 2 V -1 10/15/26, 17:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111238

  6. Benjamin Kott updated the commit message in patch set 3 V -1 10/15/26, 21:02

  7. core-ci voted on patch set 3 V -1 10/15/26, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111279

  8. Benjamin Kott rebased onto patch set 4 V -1 10/16/26, 07:45

  9. core-ci voted on patch set 4 V -1 10/16/26, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111327

  10. Benjamin Kott rebased onto patch set 5 V -1 10/16/26, 09:26

  11. core-ci voted on patch set 5 V -1 10/16/26, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111342

  12. Benjamin Kott uploaded patch set 6 V -1 10/23/26, 14:49

  13. Benjamin Kott rebased onto patch set 7 10/23/26, 15:42

  14. core-ci voted on patch set 6 V -1 10/23/26, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112334

  15. core-ci voted on patch set 7 V -1 10/23/26, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112354

  16. Benjamin Kott uploaded patch set 8 V -1 11/18/26, 10:59

  17. core-ci voted on patch set 8 V +1 11/18/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114866