Review 12.4 Merged

80686[TASK] Deny global jQuery usage via eslint rules

Benjamin Franzke CR +2 V +2 Hard +27 −315 updated 08/29/23, 10:22

Commit message

This allows to drop a npm patch that had been applied
to the TypeScript @types/jquery before, in order
to achieve the same effect.
With eslint we can additionally provide a good
hint for the developer, what to use instead.

For the v12 backport @types/jqueryui is removed
additionally, as it conflicts with the bootstrap
jquery definitions and was unused. This showed
a small adaption that needed to be changed in
upgrade-docs, which has already been fixed
in main and is reapplied in here.

Commands executed:
  npm remove patch-package
  npm install
  npm remove @types/jqueryui

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 57

  1. Benjamin Franzke commented on patch set 1 08/29/23, 09:41

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/29/23, 09:44

  3. core-ci voted on patch set 1 V -1 08/29/23, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45965

  4. Benjamin Franzke uploaded patch set 2 CR +2 V +2 08/29/23, 10:02

  5. Benjamin Franzke updated the commit message in patch set 3 CR +2 V +2 08/29/23, 10:08

  6. core-ci voted on patch set 3 V +1 08/29/23, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45970

  7. Benjamin Franzke merged patch set 4 08/29/23, 10:22