Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
80762[WIP] Cleanup RecordList
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 22
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/80762/22 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/80762/22 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Relation chain 2
-
80762 [WIP] Cleanup RecordList This change
-
main
81131[TASK] Add missing PHP types to DatabaseRecordList
The chain has patch set 6 of 8, the changes above it need a rebase.
Files 2
Review log 3355
Show 1830 earlier messages
-
Benjamin Kott uploaded patch set 1 08/30/23, 16:34
-
Benjamin Kott uploaded patch set 2 08/30/23, 16:41
-
core-ci voted on patch set 1 V -1 08/30/23, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46052
-
core-ci voted on patch set 2 V -1 08/30/23, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46053
-
Benjamin Franzke commented on patch set 2 08/31/23, 06:20
-
Benjamin Franzke commented on patch set 2 08/31/23, 06:21
DatabaseRecordList.php:990Replynvm, I see that you'll migrate that to GenericButton::class. -
Oliver Klee commented on patch set 2 08/31/23, 07:00
DatabaseRecordList.php:430UnresolvedWe can be even more specific here: `@return list<string>` (`list` means that the array keys are integers counting from 0 upwards without gaps.` -
Benjamin Kott uploaded patch set 3
V -108/31/23, 10:13 -
core-ci voted on patch set 3 V -1 08/31/23, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46079
-
Benjamin Kott uploaded patch set 4
V -108/31/23, 10:57 -
Benjamin Kott uploaded patch set 5 08/31/23, 11:02
-
Benjamin Kott uploaded patch set 6 08/31/23, 11:05
-
Benjamin Kott uploaded patch set 7 08/31/23, 11:06
-
core-ci voted on patch set 4 V -1 08/31/23, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46082
-
core-ci voted on patch set 6 V -1 08/31/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46084
-
core-ci voted on patch set 5 V -1 08/31/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46083
-
core-ci voted on patch set 7 V -1 08/31/23, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46085
-
Benjamin Kott uploaded patch set 8
V -108/31/23, 11:30 -
core-ci voted on patch set 8 V -1 08/31/23, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46088
-
Benjamin Kott uploaded patch set 9
V -108/31/23, 12:14 -
core-ci voted on patch set 9 V -1 08/31/23, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46092
-
Benjamin Kott uploaded patch set 10
V -108/31/23, 12:36 -
core-ci voted on patch set 10 V -1 08/31/23, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46094
-
Oliver Klee commented on patch set 10 08/31/23, 14:34
As adding type annotations for non-internal classes is potentially breaking, I suggest having those only in the main branch as a separate change. -
Oliver Klee commented on patch set 10 08/31/23, 14:49
Reply
(marking as not resolved) -
Oliver Klee commented on patch set 10 08/31/23, 16:46
Reply
… or target this change for main only. -
Benjamin Kott uploaded patch set 11
V -109/04/23, 13:37 -
core-ci voted on patch set 11 V -1 09/04/23, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46192
-
Benjamin Kott uploaded patch set 12
V -109/05/23, 08:18 -
core-ci voted on patch set 12 V -1 09/05/23, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46220
-
Benjamin Kott uploaded patch set 13
V -109/06/23, 07:59 -
core-ci voted on patch set 13 V -1 09/06/23, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46267
-
Benjamin Kott uploaded patch set 14
V -109/06/23, 11:47 -
core-ci voted on patch set 14 V -1 09/06/23, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46290
-
Benjamin Kott rebased onto patch set 15
V -109/06/23, 12:05 -
core-ci voted on patch set 15 V -1 09/06/23, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46292
-
Benjamin Kott rebased onto patch set 16
V -109/06/23, 12:57 -
Benjamin Kott rebased onto patch set 17 09/06/23, 13:02
-
core-ci voted on patch set 16 V -1 09/06/23, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46294
-
core-ci voted on patch set 17 V -1 09/06/23, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46297
-
Benjamin Kott uploaded patch set 18
V -109/06/23, 13:22 -
core-ci voted on patch set 18 V -1 09/06/23, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46298
-
Benjamin Kott uploaded patch set 19
V -109/08/23, 12:53 -
core-ci voted on patch set 19 V -1 09/08/23, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46392
-
Benjamin Kott uploaded patch set 20
V -109/11/23, 12:02 -
Benjamin Kott commented on patch set 20 09/11/23, 12:10
Reply
all the code is internal here, we are fine to apply the changes also to 12.4 -
core-ci voted on patch set 20 V -1 09/11/23, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46479
-
Benjamin Kott uploaded patch set 21
V -109/21/23, 13:11 -
Benjamin Kott uploaded patch set 22 09/21/23, 13:16
-
core-ci voted on patch set 21 V -1 09/21/23, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47013
-
core-ci voted on patch set 22 V -1 09/21/23, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47014
-
Christian Kuhn commented on patch set 22 08/06/24, 15:12
hey. i hope it is ok to abandon here for now for the sake of a more clean review system. this patch is huge and should probably be split into smaller dedicated pieces. please feel free to resurrect in case work on it is picked up. -
Christian Kuhn abandoned the change 08/06/24, 15:12
-
Benjamin Kott restored the change 01/23/25, 08:46
-
Oliver Hader marked it work in progress 01/23/25, 08:46
DatabaseRecordList.php:990