Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

80762[WIP] Cleanup RecordList

Benjamin Kott CR 0 V -1 Expert +989 −823 updated 01/23/25, 08:49

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 22
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/80762/22 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/80762/22 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 2

  1. 80762 [WIP] Cleanup RecordList This change

  2. main 81131[TASK] Add missing PHP types to DatabaseRecordList This change is based on it Abandoned Benjamin Kott CR 0 V 0 → 13.4, 12.4 Hard +96 −170

    The chain has patch set 6 of 8, the changes above it need a rebase.

Files 2

Review log 3355

Show 1830 earlier messages
  1. Benjamin Kott uploaded patch set 1 08/30/23, 16:34

  2. Benjamin Kott uploaded patch set 2 08/30/23, 16:41

  3. core-ci voted on patch set 1 V -1 08/30/23, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46052

  4. core-ci voted on patch set 2 V -1 08/30/23, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46053

  5. Benjamin Franzke commented on patch set 2 08/31/23, 06:20

    DatabaseRecordList.php:990

    Would be great to use `GeneralUtility::implodeAttributes($attributes, true)` for such tags.
  6. Benjamin Franzke commented on patch set 2 08/31/23, 06:21

    DatabaseRecordList.php:990 Reply

    nvm, I see that you'll migrate that to GenericButton::class.
  7. Oliver Klee commented on patch set 2 08/31/23, 07:00

    DatabaseRecordList.php:430 Unresolved

    We can be even more specific here: `@return list<string>` (`list` means that the array keys are integers counting from 0 upwards without gaps.`
  8. Benjamin Kott uploaded patch set 3 V -1 08/31/23, 10:13

  9. core-ci voted on patch set 3 V -1 08/31/23, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46079

  10. Benjamin Kott uploaded patch set 4 V -1 08/31/23, 10:57

  11. Benjamin Kott uploaded patch set 5 08/31/23, 11:02

  12. Benjamin Kott uploaded patch set 6 08/31/23, 11:05

  13. Benjamin Kott uploaded patch set 7 08/31/23, 11:06

  14. core-ci voted on patch set 4 V -1 08/31/23, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46082

  15. core-ci voted on patch set 6 V -1 08/31/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46084

  16. core-ci voted on patch set 5 V -1 08/31/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46083

  17. core-ci voted on patch set 7 V -1 08/31/23, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46085

  18. Benjamin Kott uploaded patch set 8 V -1 08/31/23, 11:30

  19. core-ci voted on patch set 8 V -1 08/31/23, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46088

  20. Benjamin Kott uploaded patch set 9 V -1 08/31/23, 12:14

  21. core-ci voted on patch set 9 V -1 08/31/23, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46092

  22. Benjamin Kott uploaded patch set 10 V -1 08/31/23, 12:36

  23. core-ci voted on patch set 10 V -1 08/31/23, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46094

  24. Oliver Klee commented on patch set 10 08/31/23, 14:34

    As adding type annotations for non-internal classes is potentially breaking, I suggest having those only in the main branch as a separate change.
  25. Oliver Klee commented on patch set 10 08/31/23, 14:49

    Reply

    (marking as not resolved)
  26. Oliver Klee commented on patch set 10 08/31/23, 16:46

    Reply

    … or target this change for main only.
  27. Benjamin Kott uploaded patch set 11 V -1 09/04/23, 13:37

  28. core-ci voted on patch set 11 V -1 09/04/23, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46192

  29. Benjamin Kott uploaded patch set 12 V -1 09/05/23, 08:18

  30. core-ci voted on patch set 12 V -1 09/05/23, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46220

  1. Benjamin Kott uploaded patch set 13 V -1 09/06/23, 07:59

  2. core-ci voted on patch set 13 V -1 09/06/23, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46267

  3. Benjamin Kott uploaded patch set 14 V -1 09/06/23, 11:47

  4. core-ci voted on patch set 14 V -1 09/06/23, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46290

  5. Benjamin Kott rebased onto patch set 15 V -1 09/06/23, 12:05

  6. core-ci voted on patch set 15 V -1 09/06/23, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46292

  7. Benjamin Kott rebased onto patch set 16 V -1 09/06/23, 12:57

  8. Benjamin Kott rebased onto patch set 17 09/06/23, 13:02

  9. core-ci voted on patch set 16 V -1 09/06/23, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46294

  10. core-ci voted on patch set 17 V -1 09/06/23, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46297

  11. Benjamin Kott uploaded patch set 18 V -1 09/06/23, 13:22

  12. core-ci voted on patch set 18 V -1 09/06/23, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46298

  13. Benjamin Kott uploaded patch set 19 V -1 09/08/23, 12:53

  14. core-ci voted on patch set 19 V -1 09/08/23, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46392

  15. Benjamin Kott uploaded patch set 20 V -1 09/11/23, 12:02

  16. Benjamin Kott commented on patch set 20 09/11/23, 12:10

    Reply

    all the code is internal here, we are fine to apply the changes also to 12.4
  17. core-ci voted on patch set 20 V -1 09/11/23, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46479

  18. Benjamin Kott uploaded patch set 21 V -1 09/21/23, 13:11

  19. Benjamin Kott uploaded patch set 22 09/21/23, 13:16

  20. core-ci voted on patch set 21 V -1 09/21/23, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47013

  21. core-ci voted on patch set 22 V -1 09/21/23, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47014

  22. Christian Kuhn commented on patch set 22 08/06/24, 15:12

    hey. i hope it is ok to abandon here for now for the sake of a more clean review system. this patch is huge and should probably be split into smaller dedicated pieces. please feel free to resurrect in case work on it is picked up.
  23. Christian Kuhn abandoned the change 08/06/24, 15:12

  24. Benjamin Kott restored the change 01/23/25, 08:46

  25. Oliver Hader marked it work in progress 01/23/25, 08:46