Review 12.4 Merged

80893[BUGFIX] Fix race condition in module router

Benjamin Franzke CR +2 V +2 Easy +9 −2 updated 09/07/23, 08:36

Commit message

The module components (like the iframe wrapper) are
created asynchronously after their implementing module
(e.g. <typo3-iframe-module>) is loaded.

The router had a preparatory check that verified
that existing module elements are reused, but missed
to verifiy whether the element has been created in
parallel while the module components javascript module
was loaded. This happens when the module changes
while the module component is loaded for the first time.

That leads to a situation that the module componenent
was created twice, which rendered two module frames
into the backend.

Also resolve a long overdue todo while at it.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 09/07/23, 07:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/07/23, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46329

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/07/23, 08:16

  4. Benjamin Franzke merged patch set 2 09/07/23, 08:36