Review 12.4 Merged

80895[TASK] Allow configuring the modal size via markup trigger

Andreas Kienast CR +2 V +2 Easy +7 −1 updated 09/07/23, 11:00

Commit message

When triggering modals via the `.t3js-modal-trigger` class, it is now
possible to configure a modal's size via the `data-size` attribute,
accepting all modal sizes:

* `small`
* `default`
* `medium`
* `large`
* `full`

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 09/07/23, 10:38

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/07/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46344

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 09/07/23, 11:00

  4. Andreas Kienast merged patch set 2 09/07/23, 11:00