Review 12.4 Merged

80993[TASK] Make ajax-data-handler visibility toggle explicit

Benjamin Franzke CR +2 V +2 Normal +109 −84 updated 09/12/23, 07:13

Commit message

Instead of parsing parameters and string replacing
parts of it we are now passing all nessesary parts
as data attributes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benjamin Franzke commented on patch set 1 09/12/23, 05:59

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/ajax-data-handler.ts * typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php * typo3/sysext/backend/Resources/Public/JavaScript/ajax-data-handler.js
  2. core-ci voted on patch set 1 V -1 09/12/23, 06:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46495

  3. Benjamin Franzke uploaded patch set 2 V -1 09/12/23, 06:38

  4. Benjamin Franzke commented on patch set 2 09/12/23, 06:38

    ajax-data-handler.ts:209

  5. core-ci voted on patch set 2 V +1 09/12/23, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46497

  6. Benjamin Kott voted on patch set 2 V +1 CR +1 09/12/23, 06:47

  7. Benjamin Franzke merged patch set 3 09/12/23, 07:13