Review 12.4 Merged

81134[BUGFIX] Add more inputs for GifBuilder hash uniqueness

Andreas Nedbal CR +2 V +2 Easy +2 −0 updated 09/20/23, 21:13

Commit message

The previous hashing inputs didn't include the X/Y coordinates
or the calculated offsets, so similarly configured GIFBUILDERs
had a high likelyhood of loading older images.

Adding more inputs, but not falling back to fully encoding all
of $this->setup should keep the performance and increase
uniqueness.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Nedbal commented on patch set 1 09/20/23, 21:02

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Imaging/GifBuilder.php
  2. Andreas Nedbal uploaded patch set 2 09/20/23, 21:04

  3. Andreas Nedbal marked it ready for review 09/20/23, 21:05

  4. core-ci voted on patch set 2 V +1 09/20/23, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46933

  5. Andreas Nedbal voted on patch set 2 V +2 CR +2 09/20/23, 21:13

  6. Andreas Nedbal merged patch set 3 09/20/23, 21:13