Review 12.4 Merged

81136[BUGFIX] Use "sample" instead of "useSample" in FAL processing

Benni Mack CR +2 V +2 Easy +10 −5 updated 09/20/23, 22:06

Commit message

When using TypoScript, the setting "sample" allows
to scale faster than with "geometry" setting.

However, when FAL was introduced the setting was called
"useSample" which never worked since TYPO3 v6.0 in
conjunction with FAL.

The option is however useful and is now working again.

The according code is moved into GraphicalFunctions
in order to avoid future access to this public property.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Benni Mack commented on patch set 1 09/20/23, 21:44

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php
  2. Benni Mack commented on patch set 2 09/20/23, 21:45

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/20/23, 21:45

  4. core-ci voted on patch set 2 V +1 09/20/23, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46942

  5. Benni Mack voted on patch set 2 V +2 CR +2 09/20/23, 22:06

  6. Benni Mack merged patch set 3 09/20/23, 22:06