Review 12.4 Merged

81139[BUGFIX] Handle FileDoesNotExistException in `cleanup:missingrelations`

Benni Mack CR +2 V +2 Easy +24 −16 updated 09/20/23, 23:07

Commit message

It's possible that file references to files exists, where
the physical file is missing. That stopped further file
reference processing in the ext:lowlevel cleanup command
`cleanup:missingrelations`.

Therefore, this change explicitly catches the concrete
`\TYPO3\CMS\Core\Resource\Exception\FileDoesNotExistException`
exception and outputs the message, without interrupting the
processing of further files.

The handling code is moved to a dedicated method to clean
up code duplication on the same step as a side-change.

Other unforeseen errors still stop the execution.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 09/20/23, 22:37

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/20/23, 22:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46957

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/20/23, 23:07

  4. Stefan Bürk merged patch set 2 09/20/23, 23:07