Review 12.4 Merged

81142[BUGFIX] Use serialized variant of setup in GifBuilder hash

Andreas Nedbal CR +2 V +2 Easy +6 −3 updated 09/21/23, 07:21

Commit message

If generated images used the exact X/Y coordinates all time (as in one documentation example) the initial image would always be reused.

Serializing the setup array using ConfigurationService::serialize keeps performance but includes enough data to never reuse similarly positioned mask images.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Nedbal commented on patch set 1 09/21/23, 07:10

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Imaging/GifBuilder.php
  2. Andreas Nedbal uploaded patch set 2 09/21/23, 07:11

  3. Andreas Nedbal marked it ready for review 09/21/23, 07:11

  4. core-ci voted on patch set 2 V +1 09/21/23, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46970

  5. Andreas Nedbal voted on patch set 2 V +2 CR +2 09/21/23, 07:21

  6. Andreas Nedbal merged patch set 3 09/21/23, 07:21