Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

81215[WIP][TASK] Autoremove CKEditor5 coupled GHS attributes from selections

Benjamin Franzke CR 0 V 0 Normal +31 −22 updated 10/18/24, 14:11

Commit message

This patch is a preparation for upstreaming our
"style"/GHS vs "link" plugin fixes by using an event that
would be integratable to the upstream data-filter module.

It fixes all issues with the `htmlA` attribute
(which is coupled to the `linkHref` attribute by the GHS/data-filter
schema specifications), but CKEditor5 misses to remove them
automatically from selections (they do for nodes, but not for
selections), which is why #102006 and #101429 added workarounds
to explicitly remove the htmlA attribute from selections.

With this idea, data-filter (part of GHS) can
remove such attribute via an event without having
the requirement to create a dependency from the link
plugin to GHS.

TODO:
 * Sign CLA & merge upstream…
 * Test test test…

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/15/81215/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/15/81215/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Relation chain 5

  1. 81215 [WIP][TASK] Autoremove CKEditor5 coupled GHS attributes from selections This change

  2. main 81176[BUGFIX] Show but preserve invalid classes in link-browser This change is based on it Merged Benjamin Franzke CR +2 V +2 → 12.4 Normal +57 −23

    The chain has patch set 2 of 3, the changes above it need a rebase.

  3. main 81168[BUGFIX] Preserve allowedClasses (non classesAnchor) in link-browser This change is based on it Merged Benjamin Franzke CR +2 V +2 → 12.4, 11.5 Easy +4 −2

    The chain has patch set 2 of 3, the changes above it need a rebase.

  4. main 81172[BUGFIX] Prevent empty links after updating a link via link-browser This change is based on it Merged Benjamin Franzke CR +2 V +2 → 12.4 Easy +16 −3

    The chain has patch set 1 of 2, the changes above it need a rebase.

  5. main 81051[BUGFIX] Use CKEditor5 GHS attribute for CSS classes in link plugin This change is based on it Merged Benjamin Franzke CR +2 V +2 → 12.4 Normal +56 −26

    The chain has patch set 5 of 6, the changes above it need a rebase.

Files 4

Review log 23

  1. Benjamin Franzke uploaded patch set 1 09/25/23, 09:36

  2. core-ci voted on patch set 1 V -1 09/25/23, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47142

  3. Oliver Hader updated the commit message in patch set 2 V -1 10/18/24, 14:11