Review 12.4 Merged

81557[BUGFIX] Mark erroneous fields within `.formengine-field-item`

Jasmina Ließmann CR +2 V +2 Easy +4 −2 updated 10/25/23, 17:22

Commit message

FormEngine UI has a rather inconsistent markup. Fields within
Flexforms may appear within another `div` container, causing issues
when trying to mark an erroneous field as such. To solve this
short-termed, additional CSS rules are added to cover such cases.

In the long run, the FormEngine markup must get consolidated.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Jasmina Ließmann commented on patch set 1 10/25/23, 17:06

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/25/23, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48188

  3. Jasmina Ließmann voted on patch set 1 V +2 CR +2 10/25/23, 17:22

  4. Jasmina Ließmann merged patch set 2 10/25/23, 17:22