Review 12.4 Merged

81560[BUGFIX] Reset UriBuilder for links generated by PasswordRecoveryService

Christian Kuhn CR +2 V +2 Easy +6 −3 updated 10/26/23, 22:48

Commit message

The `EXT:felogin/Classes/Service/RecoveryService.php` makes use of
the local $uriBuilder instance building links, however it does
not `reset()` it's state before building a URL.

It seems this only creates an issue when used in conjunction with
`EXT:vhs` (possibly due to adapted fluid/object caching behavior?).

Fixing this by resetting the instance as recommended via
https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/UriBuilder.html
should take care of this, even though uriBuilder should be a
singleton only operating within the scope of a single
ActionController.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 10/26/23, 22:37

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/26/23, 22:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48272

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/26/23, 22:48

  4. Christian Kuhn merged patch set 2 10/26/23, 22:48